Issue 1027: Skyline DDA Searches that use Percolator need to calculate all-files-q-values

issues
Status:closed
Assigned To:Guest
Type:Todo
Area:Skyline
Priority:2
Milestone:24.2
Opened:2024-06-16 22:50 by Brendan MacLean
Changed:2026-01-06 13:27 by Brendan MacLean
Resolved:2024-11-14 11:29 by Matt Chambers
Resolution:Fixed
Closed:2026-01-06 13:27 by Brendan MacLean
2024-06-16 22:50 Brendan MacLean
Title»Skyline DDA Searches that use Percolator need to calculate all-files-q-values
Assigned To»Matt Chambers
Type»Todo
Area»Skyline
Priority»2
Milestone»24.2
Currently Skyline only runs Percolator at the single-file level which will cause inflated FDR as the number of files increases, and has been shown to lead to libraries for DIA that do not do as well as ones where at least all-files-q-values are used at the peptide level. Mike has also said that Bill Noble no longer feels one should ever use PSM q values for an overall dataset cut-off as we are currently doing.

We need to figure out how to run Percolator on the full set of files at the end of our processing and build the spectral library using the all-files peptide q values, as we do with pdResult files after we found the same problem there.

2024-11-14 11:29 Matt Chambers
resolve as Fixed
Statusopen»resolved
Assigned ToMatt Chambers»Brendan MacLean
Already fixed for MSFragger. Fixing for MSAmanda would require considerable changes to the MSAmanda DLLs. Apparently core MSAmanda has already moved on to version 3.0. It might make sense to abandon the "can read from vendor formats" capability we get with our custom MSAmanda DLLs and just use the command-line MSAmanda (which can only read mzML).

2026-01-06 13:27 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest
Bulk closing resolved issues during GitHub migration.